Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: renterd libs extract route variables #581

Merged
merged 1 commit into from
Apr 16, 2024
Merged

refactor: renterd libs extract route variables #581

merged 1 commit into from
Apr 16, 2024

Conversation

alexfreska
Copy link
Member

@alexfreska alexfreska commented Apr 15, 2024 •
edited
Loading

This PR moves all renterd API route strings to shared constants that can be used across libraries. This makes updating all libraries at once easier and also avoids small string typos.

These strings are used for API routes and also data revalidation in react mutations and hooks.

This was referenced Apr 15, 2024
Merged
Merged
Merged
Merged
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Apr 15, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: 833c8f9

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

This was referenced Apr 15, 2024
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
@alexfreska Graphite App
Copy link
Member Author

alexfreska commented Apr 15, 2024 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @alexfreska and the rest of your teammates on Graphite Graphite

This was referenced Apr 15, 2024
Merged
Merged
Merged
@alexfreska alexfreska force-pushed the refactor_split_out_a_requests_library branch from 00464a3 to f2ae686 Compare April 15, 2024 15:00
@alexfreska alexfreska force-pushed the refactor_renterd_libs_extract_route_variables branch from f9c86ce to 2cf79e3 Compare April 15, 2024 15:00
@alexfreska alexfreska force-pushed the refactor_split_out_a_requests_library branch from f2ae686 to 5e33e79 Compare April 15, 2024 15:06
@alexfreska alexfreska force-pushed the refactor_renterd_libs_extract_route_variables branch from 2cf79e3 to f932321 Compare April 15, 2024 15:06
@alexfreska alexfreska force-pushed the refactor_split_out_a_requests_library branch from 5e33e79 to 245aab1 Compare April 15, 2024 15:22
@alexfreska alexfreska force-pushed the refactor_renterd_libs_extract_route_variables branch from f932321 to d82ee4d Compare April 15, 2024 15:22
@alexfreska alexfreska force-pushed the refactor_split_out_a_requests_library branch from 245aab1 to 3dce0b5 Compare April 15, 2024 15:30
@alexfreska alexfreska force-pushed the refactor_renterd_libs_extract_route_variables branch from d82ee4d to 6fb785e Compare April 15, 2024 15:30
@alexfreska alexfreska force-pushed the refactor_split_out_a_requests_library branch from 3dce0b5 to a25e53f Compare April 15, 2024 15:57
@alexfreska alexfreska force-pushed the refactor_renterd_libs_extract_route_variables branch from 6fb785e to c5edf5f Compare April 15, 2024 15:57
@alexfreska alexfreska force-pushed the refactor_split_out_a_requests_library branch from a25e53f to a03e7ac Compare April 15, 2024 16:14
@alexfreska alexfreska force-pushed the refactor_renterd_libs_extract_route_variables branch from c5edf5f to 443c8fb Compare April 15, 2024 16:14
@alexfreska alexfreska force-pushed the refactor_split_out_a_requests_library branch from a03e7ac to 68261fb Compare April 15, 2024 16:38
@alexfreska alexfreska force-pushed the refactor_renterd_libs_extract_route_variables branch from 443c8fb to 6e95d64 Compare April 15, 2024 16:38
@alexfreska alexfreska force-pushed the refactor_split_out_a_requests_library branch from 68261fb to e54efd3 Compare April 15, 2024 18:35
@alexfreska alexfreska force-pushed the refactor_renterd_libs_extract_route_variables branch 2 times, most recently from 06a0c9c to 3f50d41 Compare April 15, 2024 18:59
@alexfreska alexfreska mentioned this pull request Apr 15, 2024
Merged
@alexfreska alexfreska force-pushed the refactor_split_out_a_requests_library branch from e54efd3 to e1a4ef0 Compare April 15, 2024 19:51
@alexfreska alexfreska force-pushed the refactor_renterd_libs_extract_route_variables branch from 3f50d41 to 9b69766 Compare April 15, 2024 19:51
n8maninger
n8maninger previously approved these changes Apr 15, 2024
View reviewed changes
@n8maninger n8maninger dismissed their stale review April 15, 2024 20:12

build failed

@alexfreska alexfreska force-pushed the refactor_split_out_a_requests_library branch from e1a4ef0 to 6df9d11 Compare April 15, 2024 20:34
@alexfreska alexfreska force-pushed the refactor_renterd_libs_extract_route_variables branch from 9b69766 to 2f4023c Compare April 15, 2024 20:34
@alexfreska alexfreska force-pushed the refactor_split_out_a_requests_library branch from 6df9d11 to 6a23b40 Compare April 15, 2024 20:45
@alexfreska alexfreska force-pushed the refactor_renterd_libs_extract_route_variables branch from 2f4023c to 833c8f9 Compare April 15, 2024 21:15
@alexfreska alexfreska changed the base branch from refactor_split_out_a_requests_library to main April 15, 2024 21:15
@alexfreska alexfreska requested a review from n8maninger April 15, 2024 21:51
@alexfreska Graphite App
Copy link
Member Author

alexfreska commented Apr 16, 2024 •
edited
Loading

Merge activity

@alexfreska alexfreska merged commit 751a2b2 into main Apr 16, 2024
1 of 2 checks passed
@alexfreska alexfreska deleted the refactor_renterd_libs_extract_route_variables branch June 7, 2024 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@n8maninger n8maninger n8maninger approved these changes

@ChrisSchinnerl ChrisSchinnerl ChrisSchinnerl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
Sia
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alexfreska @ChrisSchinnerl @n8maninger